Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork the path handling code to use wide strings on Windows. #1221

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fork the path handling code to use wide strings on Windows. #1221

wants to merge 5 commits into from

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Feb 23, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 23, 2023
@github-actions
Copy link

github-actions bot commented Feb 23, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 3913a0b
Last updated: Thu Feb 23 19:03 PST 2023
View integration test log & download artifacts

Failures Configs
admob [BUILD] [ERROR] [Windows] [x64] [openssl]
analytics [BUILD] [ERROR] [Windows] [x64] [openssl]
auth [BUILD] [ERROR] [Windows] [x64] [openssl]
database [BUILD] [ERROR] [Windows] [x64] [openssl]
dynamic_links [BUILD] [ERROR] [Windows] [x64] [openssl]
firestore [BUILD] [ERROR] [Windows] [x64] [openssl]
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  QueryTest.TestWillNotGetMetadataOnlyUpdates
[TEST] [FLAKINESS] [Android] [2/3 os: macos ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
functions [BUILD] [ERROR] [Windows] [x64] [openssl]
gma [BUILD] [ERROR] [Windows] [x64] [openssl]
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdViewLoadAdAnchorAdaptiveAd
installations [BUILD] [ERROR] [Windows] [x64] [openssl]
messaging [BUILD] [ERROR] [Windows] [x64] [openssl]
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
remote_config [BUILD] [ERROR] [Windows] [x64] [openssl]
storage [BUILD] [ERROR] [Windows] [x64] [openssl]

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Feb 23, 2023
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Feb 23, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Feb 24, 2023
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Feb 24, 2023
@jonsimantov jonsimantov marked this pull request as draft February 24, 2023 00:39
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonsimantov